Skip to content

Add trusted modifier #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 27, 2021
Merged

Add trusted modifier #6149

merged 7 commits into from
Jun 27, 2021

Conversation

Kapsonfire-DE
Copy link
Contributor

@Kapsonfire-DE Kapsonfire-DE commented Mar 30, 2021 •
edited
Loading

Fixes #6137

Adding a trusted modifier to make events not be dispatchable by console/sourcecode.
Useful to prevent injected code to automatically dispatch event for preventing botting

@Kapsonfire-DE
Update dom.ts
33cf8c3 
added trusted modifier to dom.ts
@Kapsonfire-DE
Update Element.ts
f6847a6 
added trusted to valid modifiers in Element.ts
@Kapsonfire-DE
Update EventHandler.ts
8e93889 
execute trusted modifier in EventHandler.ts
@Kapsonfire-DE
Update errors.json
731799b 
extended to fix trusted
@Kapsonfire-DE
Merge pull request #1 from sveltejs/master
8eb109c 
update
tanhauhau
tanhauhau reviewed Apr 27, 2021
View reviewed changes
Copy link
Member

@tanhauhau tanhauhau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks great 👍🏻 👏

Add a test for this and everything should be good

@Kapsonfire-DE
Copy link
Contributor Author

Thanks - I hope i did it right. Never done before.

@Kapsonfire-DE
Copy link
Contributor Author

Local test:
runtime
√ event-handler-modifier-trusted (52ms)
√ event-handler-modifier-trusted (with hydration)

ssr
√ event-handler-modifier-trusted

3 passing (159ms)

@Kapsonfire-DE Kapsonfire-DE requested a review from tanhauhau April 27, 2021 14:48
@dummdidumm dummdidumm merged commit b464320 into sveltejs:master Jun 27, 2021
@Kapsonfire-DE Kapsonfire-DE deleted the add-trusted-modifier branch June 27, 2021 16:55
@benmccann benmccann mentioned this pull request Jul 25, 2021
Merged
@benmccann benmccann mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trusted events modifier
3 participants
@Kapsonfire-DE @tanhauhau @dummdidumm