Skip to content

[feat] parser errors improvements #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2021
Merged

[feat] parser errors improvements #6612

merged 2 commits into from
Aug 4, 2021

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Aug 3, 2021 •
edited
Loading

Fixes #6288 - better error for unclosed curly brace in props
Fixes #6259 - error for missing attribute values

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau changed the title [feat] better error for unclosed curly brace in props [feat] parser errors Aug 3, 2021
@tanhauhau tanhauhau changed the title [feat] parser errors [feat] parser errors improvements Aug 3, 2021
@Conduitry Conduitry merged commit 64b882e into sveltejs:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclosed curly brace in props - Error Parser unexpected behavior on value-less attribute
2 participants
@tanhauhau @Conduitry