-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: beforeUpdate
called twice with bound reference
#6858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: beforeUpdate
called twice with bound reference
#6858
Conversation
This PR doesn't touch on the cases related to reactivity, please check the comment #6685 (comment) |
ec6a9ac
to
fa7b1d4
Compare
Thanks for the extra refactors! We'll have to wait and see if the other maintainers have an opinion on this update strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes makes sense to me 👍
@rmunn is this PR still valid? |
@RaiVaibhav if you don't mind rebasing this PR, we hope to review the outstanding PRs in the coming weeks |
Hey Ben McCann, unfortunately I am not with my laptop for few days,
requesting you or anyone else to kindly continue from here
Thanks
…On Wed, Feb 22, 2023 at 11:00 AM Ben McCann ***@***.***> wrote:
@RaiVaibhav <https://github.com/RaiVaibhav> if you don't mind rebasing
this PR, we hope to review the outstanding PRs in the coming weeks
—
Reply to this email directly, view it on GitHub
<#6858 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJ7CJT456NZPN2G3AJGWXTWYWP65ANCNFSM5GJBWBYQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
You can update it a few days from now. That will be fine |
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
beforeUpdate
called twice with bound reference
Kindly let me know if I can still help |
Thank you for the offer! Svelte 5 deprecates beforeUpdate/afterUpdate in favor of |
Fixes: #6016
Fixes: #3290
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint