[feat] opt-out loopGuard for async loops #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Conduitry merged 2 commits into sveltejs:master from tanhauhau:tanhauhau/gh-6945

Dec 13, 2021

Member

tanhauhau commented Nov 27, 2021

Fixes #6945

opt-out loopguard for async loops
fix the test for opt-out loopGuard for generators (it wasn't throwing error without the fix)

Before submitting the PR, please make sure you do the following

Prefix your PR title with [feat], [fix], [chore], or [docs].
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with npm test and lint the project with npm run lint


          opt-out loopGuard for async loops

b009108

tanhauhau force-pushed the tanhauhau/gh-6945 branch from 8314b30 to b009108 Compare

November 27, 2021 15:42


          tidy

998ad53

Conduitry merged commit 6ecc3e4 into sveltejs:master

Contributor

GauBen commented Dec 24, 2021

The fix does not seem to work, please see https://svelte.dev/repl/019d33c57a284a78aced8a2dad3cfa89?version=3.44.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet