[fix]: keep space in <pre> or preserveWhitespace: true
#6990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
changed the title
<pre> or preserveWhitespace: true<pre> or preserveWhitespace: true
|
I fixed tests that was failing due to crlf on windows. Would you please run the tests again? |
|
I don't know how to fix the CI timeout. Can you let me know how to solve it? |
|
It's unrelated, don't worry about it |
tanhauhau
approved these changes
Dec 10, 2021
dummdidumm
approved these changes
Dec 10, 2021
dummdidumm
requested changes
Dec 13, 2021
There was a problem hiding this comment.
Code change looks great 👍 Could you replace the test in test/js with a runtime test inside test/runtime? You could check the rendered output via target.querySelector('something something').innerHTML. The advantage would be that these tests are more robust to compiler implementation changes and need less adjustments later on.
|
Thank you for checking this PR! I will make that change. |
dummdidumm
approved these changes
Jan 27, 2022
This was referenced Feb 12, 2022
himanshiLt
pushed a commit
to himanshiLt/svelte
that referenced
this pull request
Mar 3, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Mar 14, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 21, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt
pushed a commit
to nevilm-lt/svelte
that referenced
this pull request
Apr 22, 2022
…tejs#6990) Fixes sveltejs#6437 Fixes sveltejs#4731 Closes sveltejs#4737 Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6437
close #4731
This PR fixes to keep the space inside the
<pre>tag. Also, if the user uses thepreserveWhitespace: trueoption, it will keep the space in the same way with or without the<pre>tag.The previous compiler removes the spaces after the start tag and before the end tag. It works fine in most cases, but it doesn't output as intended inside the
<pre>tag.However, even after this fix, the space remains removed inside the mustache tag. This is intentional because I think that outputting a lot of space with
{#each}etc. may be included in the breaking change.There's already a PR #4737 about fixing
preserveWhitespace: true, but it didn't seem to be active.Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint