Skip to content

[fix] Raise compile error if variable name is same as imported variable name #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

[fix] Raise compile error if variable name is same as imported variable name #7145

merged 3 commits into from
Jan 26, 2022

Conversation

baseballyama
Copy link
Member

fix: #7090

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

bluwy
bluwy reviewed Jan 23, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this!

@baseballyama
Copy link
Member Author

By the way, I updated the variable name because it doesn't follow svelte's rule.

@baseballyama baseballyama mentioned this pull request Jan 23, 2022
Closed
5 tasks
@Conduitry Conduitry merged commit 5665f71 into sveltejs:master Jan 26, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
@baseballyama @nevilm-lt
[fix] raise compile error if variable name is same as imported variab…
4626e3b 
…le name (sveltejs#7145)
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@baseballyama @nevilm-lt
[fix] raise compile error if variable name is same as imported variab…
59b9d45 
…le name (sveltejs#7145)
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@baseballyama @nevilm-lt
[fix] raise compile error if variable name is same as imported variab…
665c4d0 
…le name (sveltejs#7145)
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
@baseballyama @nevilm-lt
[fix] raise compile error if variable name is same as imported variab…
df9ff0d 
…le name (sveltejs#7145)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear error when module import name is same as variable name
3 participants
@baseballyama @bluwy @Conduitry