Skip to content

Make buffered/played/seekable attributes of media element bindable #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Make buffered/played/seekable attributes of media element bindable #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion src/generators/dom/visitors/Element/Binding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,28 @@ export default function visitBinding(

updateConditions = [`${last} !== (${last} = ${snippet})`];
updateElement = `${state.parentNode}[${last} ? "pause" : "play"]();`;
} else if (attribute.name === 'buffered') {
const frame = block.getUniqueName(`${state.parentNode}_animationframe`);
block.addVariable(frame);
setter = deindent`
cancelAnimationFrame(${frame});
${frame} = requestAnimationFrame(${handler});
${setter}
`;

updateConditions.push(`${snippet}.start`);
readOnly = true;
} else if (attribute.name === 'seekable' || attribute.name === 'played') {
const frame = block.getUniqueName(`${state.parentNode}_animationframe`);
block.addVariable(frame);
setter = deindent`
cancelAnimationFrame(${frame});
if (!${state.parentNode}.paused) ${frame} = requestAnimationFrame(${handler});
${setter}
`;

updateConditions.push(`${snippet}.start`);
readOnly = true;
}
}

Expand Down Expand Up @@ -213,6 +235,9 @@ function getBindingEventName(node: Node, attribute: Node) {
if (attribute.name === 'currentTime') return 'timeupdate';
if (attribute.name === 'duration') return 'durationchange';
if (attribute.name === 'paused') return 'pause';
if (attribute.name === 'buffered') return 'progress';
if (attribute.name === 'seekable') return 'timeupdate';
if (attribute.name === 'played') return 'timeupdate';

return 'change';
}
Expand Down Expand Up @@ -317,4 +342,4 @@ function isComputed(node: Node) {
}

return false;
}
}
7 changes: 5 additions & 2 deletions src/validate/html/validateElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ export default function validateElement(validator: Validator, node: Node, refs:
} else if (
name === 'currentTime' ||
name === 'duration' ||
name === 'paused'
name === 'paused' ||
name === 'buffered' ||
name === 'seekable' ||
name === 'played'
) {
if (node.name !== 'audio' && node.name !== 'video') {
validator.error(
Expand Down Expand Up @@ -202,4 +205,4 @@ function checkTypeAttribute(validator: Validator, node: Node) {

function isDynamic(attribute: Node) {
return attribute.value.length > 1 || attribute.value[0].type !== 'Text';
}
}