Skip to content

fix: derived store restarting when unsubscribed from another store with a shared ancestor #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

jrouleau
Copy link
Contributor

@jrouleau jrouleau commented Mar 9, 2023

Fixes #8364

When a derived store was unsubscribed from another store sharing a common ancestor, the ancestors update loop would restart the store after it had already been stopped. This PR renames the existing inited boolean to started to be more clear about its function and resets it to false once the store has been stopped so sync() isn't run on a cold store.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@vercel
Copy link

vercel bot commented Mar 9, 2023

@jrouleau is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 127b61a into sveltejs:master Mar 14, 2023
@jrouleau jrouleau deleted the fix-derived-store-restarting branch March 14, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derived store is unsubscribed twice and started without any subscribers
2 participants