Skip to content

chore: remove prepare script #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

benmccann
Copy link
Member

It drives me insane that pnpm install takes forever because it builds the library. I don't know if there's a reason for this. Maybe @Conduitry knows if there's a reason it needs to be this way?

@benmccann benmccann added this to the 4.x milestone May 20, 2023
@vercel
Copy link

vercel bot commented May 20, 2023

@benmccann is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be ok with removing it, especially once we remove the ESM bundle. @Conduitry any objections?

@Conduitry
Copy link
Member

The goal of this was to let people point point to a Git branch in their package.json - the compiler would be built on the fly as they installed the package from Git. I don't think we should remove the prepare script before we make the repos consumable as-is as a package.

@dummdidumm
Copy link
Member

That makes sense - we shouldn't get rid of the script then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants