update type generation script

[Rich-Harris]

This PR looks bigger than it is because it incorporates version-4 commits that aren't yet in sites. We can't just merge version-4 into sites because the doc generation will break if we do.

It's not a 1:1 replacement yet (and there may be some changes needed to dts-buddy, e.g. removing unnecessary _1 suffixes from generic argument names), but it's close. We should probably put the logic in site-kit since it's duplicated between here and kit.svelte.dev

[Rich-Harris]

deleted comment, all tasks were addressed

[PuruVJ]

Ah yeah, many are because of extra logic I added to this compared to kit site. Do you mind if I directly push to this branch with appropriate changes.

About the SvelteComponent_1, can't that be fixed in dts-buddy?

[Rich-Harris]

Do you mind if I directly push to this branch with appropriate changes.

go right ahead, i'm not in the branch at the moment

About the SvelteComponent_1, can't that be fixed in dts-buddy?

i think that would be best, yeah. i'm not sure what it's doing there in the first place. will take a look when i get a chance

[PuruVJ]

This does require changes at dts-buddy level. many types and generics are sufficed with this 🤔

Also I noticed that SvelteComponentTyped's comments are not copied over, which removes the deprecated warning

Source:

Output:

Other than that, I removed the $$_attribute from Action, and reduced prettier printWidth to 60 for the code snippets, to make em more readable

[PuruVJ]

svelte/compiler doesn't work either. twoslash says it can't find svelte/compiler, whereas all other submodules are easily found.

UPDATE: None of the submodules work now. I cleared the cache in node_modules/.snippets and nothing's working now

Error compiling snippet in 04-compiler-and-api/01-svelte-compiler.md
## Code

'''js
// @filename: ambient.d.ts
/// <reference types="svelte" />
/// <reference types="svelte/action" />
/// <reference types="svelte/compiler" />
/// <reference types="svelte/easing" />
/// <reference types="svelte/motion" />
/// <reference types="svelte/transition" />
/// <reference types="svelte/store" />
/// <reference types="svelte/action" />
// @esModuleInterop

// @filename: ambient.d.ts
declare global {
  var source: string
}

export {}

// @filename: index.ts
// ---cut---
import { compile } from 'svelte/compiler';

const result = compile(source, {
  // options
});
'''
TwoslashError: 
## Errors were thrown in the sample, but not included in an errors tag

These errors were not marked as being expected: 2307. 
Expected: // @errors: 2307

Compiler Errors:

index.ts
  [2307] 37 - Cannot find module 'svelte/compiler' or its corresponding type declarations.
Please report this to https://github.com/markedjs/marked.
    at validateCodeForErrors (/Users/puruvijay/Projects/svelte/node_modules/.pnpm/@[email protected]/node_modules/@typescript/twoslash/dist/twoslash.cjs.development.js:280:18)
    at Object.twoslasher (/Users/puruvijay/Projects/svelte/node_modules/.pnpm/@[email protected]/node_modules/@typescript/twoslash/dist/twoslash.cjs.development.js:873:5)
    at Proxy.runTwoSlash (/Users/puruvijay/Projects/svelte/node_modules/.pnpm/[email protected][email protected]/node_modules/shiki-twoslash/dist/shiki-twoslash.cjs.development.js:870:26)
    at syntax_highlight (/Users/puruvijay/Projects/svelte/sites/svelte.dev/src/lib/server/markdown/renderer.js:878:43)
    at code (/Users/puruvijay/Projects/svelte/sites/svelte.dev/src/lib/server/markdown/renderer.js:114:15)
    at Renderer.code (/Users/puruvijay/Projects/svelte/sites/svelte.dev/src/lib/server/markdown/renderer.js:207:31)
    at renderer.<computed> [as code] (file:///Users/puruvijay/Projects/svelte/node_modules/.pnpm/[email protected]/node_modules/marked/lib/marked.esm.js:2782:41)
    at Parser.parse (file:///Users/puruvijay/Projects/svelte/node_modules/.pnpm/[email protected]/node_modules/marked/lib/marked.esm.js:2309:32)
    at parse (file:///Users/puruvijay/Projects/svelte/node_modules/.pnpm/[email protected]/node_modules/marked/lib/marked.esm.js:2243:19)
    at file:///Users/puruvijay/Projects/svelte/node_modules/.pnpm/[email protected]/node_modules/marked/lib/marked.esm.js:2675:18 {
  title: 'Errors were thrown in the sample, but not included in an errors tag',
  description: 'These errors were not marked as being expected: 2307. \n' +
    'Expected: // @errors: 2307',
  recommendation: 'Compiler Errors:\n' +
    '\n' +
    'index.ts\n' +
    "  [2307] 37 - Cannot find module 'svelte/compiler' or its corresponding type declarations.",
  code: '## Code\n' +
    '\n' +
    "'''js\n" +
    '// @filename: ambient.d.ts\n' +
    '/// <reference types="svelte" />\n' +
    '/// <reference types="svelte/action" />\n' +
    '/// <reference types="svelte/compiler" />\n' +
    '/// <reference types="svelte/easing" />\n' +
    '/// <reference types="svelte/motion" />\n' +
    '/// <reference types="svelte/transition" />\n' +
    '/// <reference types="svelte/store" />\n' +
    '/// <reference types="svelte/action" />\n' +
    '// @esModuleInterop\n' +
    '\n' +
    '// @filename: ambient.d.ts\n' +
    'declare global {\n' +
    '  var source: string\n' +
    '}\n' +
    '\n' +
    'export {}\n' +
    '\n' +
    '// @filename: index.ts\n' +
    '// ---cut---\n' +
    "import { compile } from 'svelte/compiler';\n" +
    '\n' +
    'const result = compile(source, {\n' +
    '  // options\n' +
    '});\n' +
    "'''"
}

[Rich-Harris]

The _1 suffixes are fixed by #8727

[PuruVJ]

Nice!!

Are you facing these same errors as well? Where it can't find svelte modules at all? I thought it was something with twoslash, but then I went into the d.ts files inside type-gen folder that we had and even then VSCode was erroring out