fix(site-2): Docs redirect page #8718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PuruVJ this PR has a merge conflict. Any reason it's marked as draft? |
|
It's not draft 😅 Fixed merge conflict. Vercel build might fail though, none of the typescript changes are working, and prolly wont work until the other PR about updating type gen script is merged |
benmccann
approved these changes
Jun 12, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the the redirects page
/docswas actually not working on the deployed site, but working locally. Its because it hasprerender = falseto avoidhandleMissingIDerror, which would cause error on deployed version as it would try to fetch the docs.mdfiles on every visit, and the files just don't exist.This change avoids calling the
get_docs_datafunction altogether