chore: use $$props directly where possible

[Rich-Harris]

Now that $$props is always an object, it makes no sense to hide props behind a function call:

-const foo = $.prop($$props, 'foo');
-console.log(foo());
+console.log($$props.foo);

We still need prop_source for reassigned (or mutated, in mutable mode) props or those with initial values, though I expect there's room for tweaks there as well

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• Prefix your PR title with feat:, fix:, chore:, or docs:.
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests and linting

• Run the tests with pnpm test and lint the project with pnpm lint

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3f84c4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
svelte-5-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 6, 2023 7:26pm

[dummdidumm]

Once code style comment, otherwise good to go

[dummdidumm]

These are almost identical, which makes it a bit hard to understand what's the difference. Also, these checks are identical to those in other places, which makes them prone to get out of sync. I think it would be better to have a function uses_prop_source (one for legacy, one for runes mode, because they are slightly different) and then use them in legacy/runes files at the respective locations.

[Rich-Harris]

ah, they actually are identical in practice — consolidated them. agree that it would be good to have a uses_prop_source check eventually, I was just holding off for now because it may make sense to have a separate prop_fallback helper for props with fallback values but no updates; looking into that currently