-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: add GamepadEventHandler type #9861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: b049d64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@ntsd is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
Thank you! Do you need this in Svelte 4 as well? Because this PR targets the Svelte 5 branch. |
Yes, but not sure where to add. Oh thank you I just saw |
The Svelte 4 branch is |
b49c02b
to
16a230c
Compare
Add GamepadEventHandler type for window.addEventListener `gamepadconnected` and `gamepaddisconnected`
16a230c
to
fcfb00b
Compare
Done, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Remember to create the same PR (minus the ongame...
variants) again the svelte-4
branch.
Thank you, Link to the Svelte 4 PR #9864. |
Add GamepadEventHandler type for window.addEventListener
gamepadconnected
andgamepaddisconnected
Ref: https://developer.mozilla.org/en-US/docs/Web/API/GamepadEvent
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint