Skip to content

OpenAPI 3.x.y - all the required fields validation needs to take account of $ref field #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
char0n opened this issue Nov 9, 2022 · 1 comment
Closed

OpenAPI 3.x.y - all the required fields validation needs to take account of $ref field #2264

char0n opened this issue Nov 9, 2022 · 1 comment
Assignees
@char0n
Labels
ApiDOM bug Something isn't working OpenApi 3.0 OpenAPI 3.1

Comments

@char0n
Copy link
Member

char0n commented Nov 9, 2022

If we have spec object, that can be referenced with Reference Object and it contains fixed fields that are required, we need to make sure, that --required lint rules only triggeres where $ref field is missing.

NOTE: please also check AsyncAPI rules if they are OK as part of this issue, if not, please create separate issue for AsyncAPI
@char0n char0n mentioned this issue Nov 9, 2022
Closed
@char0n char0n self-assigned this Nov 11, 2022
@char0n
Copy link
Member Author

char0n commented Nov 11, 2022

Problem already manifested and reported in swagger-api/swagger-editor#3652

char0n added a commit that referenced this issue Nov 11, 2022
@char0n
fix(ls): fix required lints in OpenAPI
2dd5add 
Required lints are now performed only when
 field is missing.

Refs #2264
Refs swagger-api/swagger-editor#3652
@char0n char0n mentioned this issue Nov 11, 2022
Merged
char0n added a commit that referenced this issue Nov 11, 2022
@char0n
fix(ls): fix required lints in OpenAPI
b8046bd 
Required lints are now performed only when
 field is missing.

Refs #2264
Refs swagger-api/swagger-editor#3652
@char0n char0n closed this as completed Nov 11, 2022
@char0n char0n mentioned this issue Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
ApiDOM bug Something isn't working OpenApi 3.0 OpenAPI 3.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@char0n