Skip to content

Form post support in generated clients #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deardooley opened this issue Mar 15, 2013 · 11 comments
Closed

Form post support in generated clients #39

deardooley opened this issue Mar 15, 2013 · 11 comments

Comments

@deardooley
Copy link

Thank you for the great work on this project. I was implementing this on our api earlier today and I noticed a discrepancy in the swagger-ui and swagger-codegen projects. Support for defining and posting HTML forms was recently added to swagger-core and swagger-ui. I'm wondering if it was just a matter of time before post form support makes its way into swagger-codegen or if it is not on the roadmap. If there are not plans to add it anytime soon, I'm happy to send a pull request with the changes I made to support form submission in php and java. I'm afraid someone with other language expertise would need to check out the mustache templates in other languages. There's also the chance that I'm completely missing something conceptually. If so, please let me know. Thanks again for the great work.

@fehguy
Copy link
Contributor

fehguy commented Mar 18, 2013

Howdy,
Yes, the codegen will get out of sync with the swagger spec for certain languages. We recently added file upload support to the scala and objective-c clients, but it will take longer to propagate to other languages. So help supporting them would be great! Pull requests are welcome, and if tested, can be accepted fairly quickly

@deardooley
Copy link
Author

If the code is in github, I'm happy to take a shot at php and java. I might be able to take a stab at python and python3, but no promises.

Rion

On Mar 17, 2013, at 11:52 PM, "Tony Tam" [email protected] wrote:

Howdy,
Yes, the codegen will get out of sync with the swagger spec for certain languages. We recently added file upload support to the scala and objective-c clients, but it will take longer to propagate to other languages. So help supporting them would be great! Pull requests are welcome, and if tested, can be accepted fairly quickly


Reply to this email directly or view it on GitHub.

@fehguy
Copy link
Contributor

fehguy commented Mar 18, 2013

@xhh
Copy link
Contributor

xhh commented Sep 2, 2014

Form post (form parameters) are still not supported in the Ruby client, right? (see #253)

Do you have any plans on it?

@fehguy
Copy link
Contributor

fehguy commented Sep 5, 2014

yes we'd like to support it. we're working on a major update to the tools now

@xhh
Copy link
Contributor

xhh commented Oct 8, 2014

According to the generated Java SDK, client/ApiInvoker, formParams is only supported in "PUT" requests. It should also be supported in "POST" requests, right?

@fehguy fehguy added this to the v2.1.0 milestone Dec 24, 2014
@xhh
Copy link
Contributor

xhh commented Apr 24, 2015

Form post support is added to Java codegen with #681.

@wing328
Copy link
Contributor

wing328 commented Jun 16, 2015

Based on my knowledge, this is done for Java, Android, Scala, Ruby, ObjC, Perl, Python, PHP, C#.

@webron
Copy link
Contributor

webron commented Jun 16, 2015

And what would it be missing for? :)

@wing328
Copy link
Contributor

wing328 commented Jun 16, 2015

Well I can't confirm for C++ (Tizen and Qt5)

@wing328
Copy link
Contributor

wing328 commented Nov 29, 2017

Most generators have proper support for form parameters. Closing this.

@wing328 wing328 closed this as completed Nov 29, 2017
soggier pushed a commit to abacusresearch/swagger-codegen that referenced this issue Mar 29, 2018
Migrate {{#isInteger}}, {{#isLong}}, {{#isDouble}}, {{#isFloat}}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants