[Typescript][Angular] bug: Enum generates empty name. #6822

HermenOtter · 2017-10-26T13:33:02Z

Description

I think something went wrong when the enum generation recently changed. It currently generates empty names?

Swagger-codegen version

The current(time of writing) master (commit f78d958 ))

Swagger declaration file content or url

The defined enum:

indicatie_actief:
    type: "string"
    maxLength: 1
    description: "Indication whether the object is active or not"
    enum: 
    - J
    - N

Referenced in:

responses:
        200:
          description: "Status 200"
          schema:
            type: "object"
            properties:
              items:
                type: "array"
                items:
                  type: "object"
                  allOf:
                  - type: "object"
                    properties:
                      ...more props...
                      indicatie_actief:
                        $ref: "#/definitions/indicatie_actief"

Results in:


export const  = {
    J: 'J' as ,
    N: 'N' as 
}

Bug: The names are missing
Any ideas how to fix?

Command line used for generation

generate -i -l typescript-angular

The text was updated successfully, but these errors were encountered:

macjohnny · 2017-10-27T11:30:48Z

@bedag-moo could you have a look at this?

bedag-moo · 2017-10-27T13:51:59Z

That is not my code; emitting this const was added by @kenisteward in f7471ad

kenisteward · 2017-10-27T14:15:40Z

I'll take a look at this. Could you give me the complete example of your yaml or is this it?

kenisteward · 2017-10-27T14:16:28Z

Also could you give me the full model generation so I can make sure I know what is wrong

kenisteward · 2017-10-27T14:20:39Z

@HermenOtter I have a feeling it is because I used enum name somewhere I should have used class name but when I get your fully generated model example and a yaml to go off I can check for sure

kenisteward · 2017-10-27T14:42:36Z

@HermenOtter Please check #6833 changes on my forked repo to see if it fixes your issue

HermenOtter · 2017-10-30T08:44:36Z

Thank you all for the fast responses. @kenisteward I tried your pull request with mvn clean package, but it didn't seem to work when I generated code from the new build. While building it gave a ton of warnings, but not sure if that is relevant.

edit:
What more do you need?

 responses:
        200:
          description: "Status 200"
          schema:
            type: "object"
            properties:
              items:
                type: "array"
                items:
                  type: "object"
                  allOf:
                  - type: "object"
                    properties:
                      code_bik:
                        type: "string"
                      bik:
                        type: "string"
                      indicatie_actief:
                        $ref: "#/definitions/indicatie_actief"

indicatieActief.ts

export type  = 'J' | 'N';

export const  = {
    J: 'J' as ,
    N: 'N' as 
}
``

kenisteward · 2017-10-30T12:27:21Z

Just give me the bare bone properly configures yaml file while making sure you replace all the names. I'm using enums as well and not having this issue so I need an example to debug .

…

On Mon, Oct 30, 2017, 4:44 AM Hermen Otter ***@***.***> wrote: Thank you all for the fast responses. @kenisteward <https://github.com/kenisteward> I tried your pull request with mvn clean package, but it didn't seem to work when I generated code from the new build(it had a ton of warnings btw, not sure if that is relevant). I am not sure how much of the yaml file and the models I can post, I am checking that currently and will report back. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6822 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMPLtY-RqRREQo335BPpDuw6LfJ0D_Eoks5sxYx6gaJpZM4QHk5q> .

kenisteward · 2017-10-30T12:29:46Z

Also I just wanna make sure. It is generating the type part but not the const part. Also could you try it outside of the all of with my branch ? On Mon, Oct 30, 2017, 8:27 AM Kenneth Steward <[email protected]> wrote:

…

Just give me the bare bone properly configures yaml file while making sure you replace all the names. I'm using enums as well and not having this issue so I need an example to debug . On Mon, Oct 30, 2017, 4:44 AM Hermen Otter ***@***.***> wrote: > Thank you all for the fast responses. @kenisteward > <https://github.com/kenisteward> I tried your pull request with mvn > clean package, but it didn't seem to work when I generated code from the > new build(it had a ton of warnings btw, not sure if that is relevant). > > I am not sure how much of the yaml file and the models I can post, I am > checking that currently and will report back. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#6822 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AMPLtY-RqRREQo335BPpDuw6LfJ0D_Eoks5sxYx6gaJpZM4QHk5q> > . >

HermenOtter · 2017-10-30T14:16:37Z

These are the definitions:

definitions:
  indicatie_actief:
    type: "string"
    description: "Indication whether the object is active or not"
    enum: 
      - "J"
      - "N"
  indicatie_uniek:
    type: "string"
    description: "Indication whether the object is unique or not"
    enum: 
      - "J"
      - "N"

@kenisteward I have been researching the issue and it seems you can't declare an enum in the root of a definition or something with the allOf like you said.

I will try a code generation without using allOf and then report back to you.

Do you have any idea on how to rewrite it having the same result, but without using an allOf?

HermenOtter · 2017-10-30T14:24:17Z

 Soorten_relatie:        
    type: "object"
    required:
      - "code_soort_relatie"
      - "soort_relatie"
      - "indicatie_uniek"
      - "indicatie_actief"
    properties:
      code_soort_relatie:
        type: "string"
        maxLength: 3
      soort_relatie: 
        type: "string"
        maxLength: 40
      indicatie_uniek:
        $ref: "#/definitions/indicatie_uniek"
      indicatie_actief:
        $ref: "#/definitions/indicatie_actief"

Here is it used without an allOf.

import { IndicatieActief } from './indicatieActief';
import { IndicatieUniek } from './indicatieUniek';


export interface SoortenRelatie {
    codeSoortRelatie: string;
    soortRelatie: string;
    indicatieUniek: IndicatieUniek;
    indicatieActief: IndicatieActief;
}

It references IndicatieActief properly, but it does not generate the IndicatieActief nor IndicatieUniek.
However when I use an enum as property on a definition is does work.

kenisteward · 2017-10-30T19:24:52Z

@HermenOtter Good news! I think I may have found the issue. The mustache template variable for class name should have been {{classname}} but i made it {{className}} in mine. my apologies. check my pr for the latest. Sorry for the issue!

I made sure to use your exmaples using allof as well.

HermenOtter · 2017-10-31T08:55:41Z

@kenisteward I tried your new pr, but it doesn't seem to work. Are there any additional steps I have to perform to make it work? Can you show the allOf example that works for you?

Thank you for your effort I appreciate it. ps.

kenisteward · 2017-10-31T20:00:17Z

@HermenOtter
This is what I used and it generates fine.

the definitions section is copied right from what you gave.

swagger: "2.0"
info:
  description: "This is a sample server Petstore server.  You can find out more about     Swagger at [http://swagger.io](http://swagger.io) or on [irc.freenode.net, #swagger](http://swagger.io/irc/).      For this sample, you can use the api key `special-key` to test the authorization     filters."
  version: "1.0.0"
  title: "Swagger Petstore"
  termsOfService: "http://swagger.io/terms/"
  contact:
    email: "[email protected]"
  license:
    name: "Apache 2.0"
    url: "http://www.apache.org/licenses/LICENSE-2.0.html"
host: "petstore.swagger.io"
basePath: "/v2"
tags:
- name: "pet"
  description: "Everything about your Pets"
  externalDocs:
    description: "Find out more"
    url: "http://swagger.io"
- name: "store"
  description: "Access to Petstore orders"
- name: "user"
  description: "Operations about user"
  externalDocs:
    description: "Find out more about our store"
    url: "http://swagger.io"
schemes:
- "http"
paths:
  /pets:
    get:
       responses:
              200:
                description: "Status 200"
                schema:
                  type: "object"
                  properties:
                    items:
                      type: "array"
                      items:
                        type: "object"
                        allOf:
                        - type: "object"
                          properties:
                            code_bik:
                              type: "string"
                            bik:
                              type: "string"
                            indicatie_actief:
                              $ref: "#/definitions/indicatie_actief"
definitions:
  indicatie_actief:
    type: "string"
    description: "Indication whether the object is active or not"
    enum: 
      - "J"
      - "N"
  indicatie_uniek:
    type: "string"
    description: "Indication whether the object is unique or not"
    enum: 
      - "J"
      - "N"

HermenOtter · 2017-11-01T09:06:43Z

@kenisteward
Seems there was some caching issue with the swagger specification being retrieved from swaggerhub. It is working now!

Thank you very much for your effort.

kenisteward · 2017-11-02T13:40:48Z

Has my pr been merged?

…

On Thu, Nov 2, 2017, 9:35 AM Hermen Otter ***@***.***> wrote: Closed #6822 <#6822>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6822 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMPLtSyIPu4VbJHQyvJpXzl_aYxhEO8Xks5sycU9gaJpZM4QHk5q> .

kenisteward mentioned this issue Oct 27, 2017

[TypeScript][Angular] Attempts to fix issues that causes enums that are not generated with a class to not generate correctly #6833

Merged

4 tasks

HermenOtter closed this as completed Nov 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Typescript][Angular] bug: Enum generates empty name. #6822

[Typescript][Angular] bug: Enum generates empty name. #6822

HermenOtter commented Oct 26, 2017 •

edited

Loading

macjohnny commented Oct 27, 2017

bedag-moo commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

HermenOtter commented Oct 30, 2017 •

edited

Loading

kenisteward commented Oct 30, 2017 via email

kenisteward commented Oct 30, 2017 via email

HermenOtter commented Oct 30, 2017 •

edited

Loading

HermenOtter commented Oct 30, 2017 •

edited

Loading

kenisteward commented Oct 30, 2017

HermenOtter commented Oct 31, 2017 •

edited

Loading

kenisteward commented Oct 31, 2017

HermenOtter commented Nov 1, 2017

kenisteward commented Nov 2, 2017 via email

[Typescript][Angular] bug: Enum generates empty name. #6822

[Typescript][Angular] bug: Enum generates empty name. #6822

Comments

HermenOtter commented Oct 26, 2017 • edited Loading

Description

Swagger-codegen version

Swagger declaration file content or url

Command line used for generation

macjohnny commented Oct 27, 2017

bedag-moo commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

kenisteward commented Oct 27, 2017

HermenOtter commented Oct 30, 2017 • edited Loading

kenisteward commented Oct 30, 2017 via email

kenisteward commented Oct 30, 2017 via email

HermenOtter commented Oct 30, 2017 • edited Loading

HermenOtter commented Oct 30, 2017 • edited Loading

kenisteward commented Oct 30, 2017

HermenOtter commented Oct 31, 2017 • edited Loading

kenisteward commented Oct 31, 2017

HermenOtter commented Nov 1, 2017

kenisteward commented Nov 2, 2017 via email

HermenOtter commented Oct 26, 2017 •

edited

Loading

HermenOtter commented Oct 30, 2017 •

edited

Loading

HermenOtter commented Oct 30, 2017 •

edited

Loading

HermenOtter commented Oct 30, 2017 •

edited

Loading

HermenOtter commented Oct 31, 2017 •

edited

Loading