Skip to content

Copy dataformat if property field is an array. #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

sreeshas
Copy link
Contributor

If a type's field is an array or map, dataFormat of the innerProperty was not copied
into encapsulating property. This change fixes it.

PR checklist

  • Read the contribution guildelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

If a type's field is an array or map, dataFormat of the innerProperty was not copied
into encapsulating property. This change fixes it.
@wing328
Copy link
Contributor

wing328 commented Feb 1, 2017

@sreeshas thanks for the fix, which looks reasonable to me.

@wing328 wing328 added this to the v2.2.2 milestone Feb 1, 2017
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
If a type's field is an array or map, dataFormat of the innerProperty was not copied
into encapsulating property. This change fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants