Skip to content

[Scala] Allow for UUID types in akka-scala #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2017

Conversation

rmalleman
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

imported java.util.UUID in the model to allow for UUID types

@rmalleman rmalleman closed this Mar 15, 2017
@rmalleman rmalleman reopened this Mar 15, 2017
@wing328 wing328 added this to the v2.2.3 milestone Mar 15, 2017
@wing328
Copy link
Contributor

wing328 commented Mar 15, 2017

@rmalleman thanks for the PR.

Starting from 2.3.0 (next major release), we'll consolidate scala and async-scala into a single scala generator via #4855. When you've time, please give it a try and let us know if you've any feedback.

Ideally we want to merge "akka-scala" into scala generator as an option/switch (e.g. --supportAkka). Please let us know if you've any feedback/concern on this.

(for your upcoming PRs, I would suggest you to create a new branch as per bit best practices)

@wing328 wing328 merged commit b2aa877 into swagger-api:master Mar 15, 2017
@wing328
Copy link
Contributor

wing328 commented Mar 15, 2017

If your company is using Swagger Codegen, please consider adding your company name to this list

@rmalleman
Copy link
Contributor Author

rmalleman commented Mar 15, 2017

Consolidation sounds great, ill give that pr a go. Thanks for accepting.

@wing328 wing328 changed the title Allow for UUID types in akka-scala [Scala] Allow for UUID types in akka-scala Mar 20, 2017
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
* allow for UUID types

* update sample libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants