Skip to content

[Java][Feign] Updated feign library to use latest version of OpenFeign and Jackson. #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2017

Conversation

oteichmann
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Issue-5107

@wing328
Copy link
Contributor

wing328 commented Mar 19, 2017

@oteichmann thanks for the PR, which has been merged into master.

(linked to #5107)

@wing328
Copy link
Contributor

wing328 commented Mar 19, 2017

FYI. I pushed the change from master to 2.3.0 via f477ae8.

I tried to updated jackson threepane version to the latest (2.8.4) but got the following error message:

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /private/tmp/swagger-codegen/samples/client/petstore/java/feign/src/main/java/io/swagger/client/CustomInstantDeserializer.java:[8,49] cannot find symbol
  symbol:   class DateTimeUtils
  location: package com.fasterxml.jackson.datatype.threetenbp
[INFO] 1 error

Looks like DateTimeUtils has been removed in the latest version. For the time being, I keep the version at 2.6.4.

cc @cbornet

@wing328 wing328 mentioned this pull request Mar 19, 2017
@cbornet
Copy link
Contributor

cbornet commented Mar 19, 2017

Yes DateTimeUtils.timeZoneToZoneId() is now in org.threeten.bp.DateTimeUtils.toZoneId().
We should also check if this custom deserializer is still needed with the new jackson version.

@cbornet
Copy link
Contributor

cbornet commented Mar 19, 2017

I confirm that the CustomInstantDeserializer is not needed anymore with the new jackson and it must be removed.

pgrm added a commit to apaleo/swagger-codegen that referenced this pull request Mar 19, 2017
* [Swift] Detect file type in Swift codegen

* Fix Issue swagger-api#5063 (deleting wrong sample files) (swagger-api#5064)

* Update samples for springboot, spring-delegate, spring-delegate-j8.

* Issue swagger-api#5063: delete samples in the correct directory.

* fix link to Cummins

* Update wordnik.yaml

* Update wordnik.yaml

* add https://github.com/christopheradams/elixir_style_guide

* add https://github.com/inaka/erlang_guidelines

* [Haskell] Fix broken client/server compilation errors (swagger-api#5097)

* Remove dead legacy code

* Update cosmetics according to Haskell standard practices

* Fix failing pattern matching for lookupEither

* Bump to latest dependencies without any breaking changes

* Remove duplicate instance declarations already existing in Servant.API.Verbs

* Fix double Java/Haskell escapement bug

* Re-generate Petstore sample client/server

* Add Selective Generation support to the Maven plugin. (swagger-api#5036)

* Updated maven plugin to allow for selective generation

* Documentation of Selective generation options.

* Update petstore samples for scala client. (swagger-api#5092)

* Update petstore samples for scala client.

* Fix missing dependency problem.

* Fix sample script to set the correct artifact ID in the generated POM (swagger-api#5094)

* Update samples for akka.

* Have akka-scala-petstore scripts set the correct artifact names

* Update akka-scala samples again.

* Update samples for C#/SwaggerClientWithPropertyChanged. (swagger-api#5095)

* Swift3 enum: number variable names fix (swagger-api#5060)

* Swift3 enum: number variable names fix

Swift3 generator: added 'number' prefix to enum variable names that start with a number

* Fixed Swift3 enum variable names starting with number (prefixed with '_') and added test cases

* Swift3 enum var names: made sure to keep the next word after a number in lower case

* add jackson dependencies to pom for cxf-client swagger-api#4924 (swagger-api#5032)

* add petstore sample for jaxrs-cxf-client, update travis ci (swagger-api#5111)

* fix path with {{{ .. }}} in c# api mustache file (swagger-api#5112)

* Updated feign library to use latest version of OpenFeign and Jackson. (swagger-api#5114)
@wing328 wing328 changed the title Updated feign library to use latest version of OpenFeign and Jackson. [Java][Feign] Updated feign library to use latest version of OpenFeign and Jackson. Mar 20, 2017
spr3nk3ls pushed a commit to spr3nk3ls/swagger-codegen that referenced this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants