Skip to content

Making default PHP namespace generic and fix issues 628 and 635 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2015
Merged

Making default PHP namespace generic and fix issues 628 and 635 #630

merged 3 commits into from
Apr 14, 2015

Conversation

who
Copy link
Contributor

@who who commented Apr 13, 2015

This fixes issue #628, which causes name collision.

@who who changed the title A proposed fix for Issue #628 Making default PHP namespace name more generic, and a fix for Issue #628 Apr 13, 2015
@wing328
Copy link
Contributor

wing328 commented Apr 14, 2015

@who, thanks for submitting a PR to make the namespace name more generic.

I was the one who temporarily hard-coded the namespace/package name. I was thinking about using the host name in the base URL to come up with a better namespace name. For example, if the base URL is http://api.foursquare.com, the package will be "foursquare-php".

Do you think this would be a better approach to name the namespace by default?

@who
Copy link
Contributor Author

who commented Apr 14, 2015

@wing328 Not everyone will use that naming convention, so might as well go with a generic one (hence "SwaggerClient") until it's fully customizable with a command line parameter, json setting payload, or by other means.

@fehguy
Copy link
Contributor

fehguy commented Apr 14, 2015

Please chime in with any suggestions to #616

@who who changed the title Making default PHP namespace name more generic, and a fix for Issue #628 Making default PHP namespace generic and fix issues 628 and 635 Apr 14, 2015
fehguy added a commit that referenced this pull request Apr 14, 2015
Making default PHP namespace generic and fix issues 628 and 635
@fehguy fehguy merged commit dfa17d2 into swagger-api:develop_2.0 Apr 14, 2015
@dariusz
Copy link

dariusz commented May 25, 2015

+1 on just making it generic. ApiClient, SwaggerClient, etc. would be great. Anything other than PetStore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants