Skip to content

2.10.1 dist files contain absolute URLs #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eminence opened this issue May 11, 2016 · 2 comments
Closed

2.10.1 dist files contain absolute URLs #930

eminence opened this issue May 11, 2016 · 2 comments

Comments

@eminence
Copy link

Hello!

I just downloaded the 2.10.1 release from github. It seems that several javascript and CSS paths are referenced using absolute paths that start with /dist/. This causes problems when swagger-editor is hosted somewhere other than the root of your web server. For example, in style.css:

url(/dist/ab28ef22f46ea6dfec154abb4be50aba.woff)

If I've deployed swagger-editor into a directory named swagger-editor, instead of requesting something like /swagger-editor/dist/ab28ef22f46ea6dfec154abb4be50aba.woff the request is for /dist/ab28ef22f46ea6dfec154abb4be50aba.woff which a 404.

@saharj saharj added this to the 2.10.2 milestone May 12, 2016
saharj added a commit that referenced this issue May 12, 2016
@saharj
Copy link
Contributor

saharj commented May 12, 2016

With 5408972 there will be only fonts that suffer from issue. That's an issue in Webpack's file-loader module which is reported here webpack-contrib/file-loader#62

@saharj
Copy link
Contributor

saharj commented May 12, 2016

I've reverted 5408972 but this doesn't mean we will not fix this in the next release. We need to fix it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants