Skip to content

fix deepObject serialization #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2018
Merged

Conversation

championswimmer
Copy link
Contributor

@championswimmer championswimmer commented Jan 29, 2018

fix deepObject serialization

Description

This will fix the problem described in might fix swagger-api/swagger-ui#4064

Motivation and Context

The deepObject style does not work as per described in teh spec

swagger-api/swagger-ui#4064

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shockey shockey added this to the February 2, 2018 milestone Feb 1, 2018
@shockey shockey merged commit 8818f2d into swagger-api:master Feb 2, 2018
@shockey
Copy link
Contributor

shockey commented Feb 2, 2018

thanks @championswimmer!

rook2pawn pushed a commit to rook2pawn/swagger-js that referenced this pull request Feb 20, 2018
* fix deepObject serialization 

might fix  swagger-api/swagger-ui#4064

* lint fix

* fix: test: deepObject can be used with explode: true only

as per the spec only explode = true allowed for deepObject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sending an object list in the URL
2 participants