Bugfix for #3610 #3612
Merged
Bugfix for #3610 #3612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2017 23:43
…result the mouse pointer is not a pointer as it is no longer a hyperlink, setting the cursor explicitly to pointer.
|
Thanks for this, @invictusmaneo! I made a small change: I moved the Turns out that passing |
|
Merged! 🎉 This code will go live tonight, as part of our weekly release. Thanks for the bug report and PR, @invictusmaneo! |
|
Nice! Thanks @shockey learned something new today 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3610
If deeplinking is disabled, removed the href attribute from the anchor tag fix because empty href points to the base location of the website which causes problems in any SPA.
A side effect is that when an anchor tag has no href it is no longer a hyperlink hence browsers do not show the hand pointer when we hover over it, so setting the pointer to default explicitly.