Skip to content

Fixes #3032 - Wrong property order #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2017
Merged

Fixes #3032 - Wrong property order #3655

merged 6 commits into from
Sep 13, 2017

Conversation

owenconti
Copy link
Contributor

Fixes #3032

fromJS does not maintain the order of the properties in the object. Instead, we use the optional reviver function to parse each property in the original schema object as an OrderedMap.

…nction with fromJS inside the response.jsx component for the passed down schema prop.
@owenconti owenconti requested a review from shockey September 12, 2017 02:35
@shockey
Copy link
Contributor

shockey commented Sep 12, 2017

@owenconti can I get some Enzyme tests for this?

@owenconti
Copy link
Contributor Author

Will do. I also found a fromJSOrdered in the utils.js file. I will try using that too.

@owenconti
Copy link
Contributor Author

owenconti commented Sep 13, 2017

@shockey I've added a basic enzyme test for response.jsx. I've also created an issue to further test that the <ObjectModel /> component is rendering properties in the order passed-in.

#3658

@shockey shockey merged commit c7cb902 into swagger-api:master Sep 13, 2017
@shockey
Copy link
Contributor

shockey commented Sep 13, 2017

@owenconti thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants