Skip to content

Handle new suitesparse version #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Handle new suitesparse version #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2ab16
Handle new suiteparse version
AlttiJokinen Jan 11, 2024
9b10f6c
Fix mistake
AlttiJokinen Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Findsuitesparse.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ endif()
find_path(suitesparse_cholmod_INCLUDE_DIR
NAMES cholmod.h
HINTS ${SUITESPARSE_DIRS}
PATH_SUFFIXES include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep the include suffix for the Linux installs and older versions on Mac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I made mistake, it should have been include and not suitesparse

PATH_SUFFIXES "include" "include/suitesparse"
)

find_path(suitesparse_spqr_INCLUDE_DIR
NAMES SuiteSparseQR.hpp
HINTS ${SUITESPARSE_DIRS}
PATH_SUFFIXES include
PATH_SUFFIXES "include" "include/suitesparse"
)

find_library(suitesparse_cholmod_LIBRARY
Expand Down