Skip to content

Fix importing of latest protobuf version #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Fix importing of latest protobuf version #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd27b57
Fix importing of latest protobuf version
RReichert Apr 28, 2025
89dd004
ammend
RReichert Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions FindGrpc.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
include("GenericFindDependency")

option(ABSL_PROPAGATE_CXX_STD "Use CMake C++ standard meta features (e.g. cxx_std_11) that propagate to targets that link to Abseil" true)
option(protobuf_INSTALL "Install protobuf binaries and files" OFF)
Copy link
Contributor Author

@RReichert RReichert Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to apply these changes here because gRPC also include protobuf internally

option(utf8_range_ENABLE_INSTALL "Configure installation" OFF)

GenericFindDependency(
TARGET grpc++
Expand Down
3 changes: 3 additions & 0 deletions FindProtobuf.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
# WARRANTIES OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE.
#

option(protobuf_INSTALL "Install protobuf binaries and files" OFF)
option(utf8_range_ENABLE_INSTALL "Configure installation" OFF)

include("GenericFindDependency")
option(protocol_BUILD_TESTS "" OFF)
GenericFindDependency(
Expand Down