Add option for suppression file in valgrind memcheck [AP-3695] #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for specifying a Valgrind suppression file via CMake, allowing users to pass a --suppressions flag relative to the repo root when running memcheck.
- Extend
swift_add_valgrind_memcheckto accept aSUPPRESSIONS_FILEargument - Append
--suppressions=<path>to Valgrind options if provided
Comments suppressed due to low confidence (2)
Valgrind.cmake:297
- Consider updating any related README or CMake usage docs to mention the new
SUPPRESSIONS_FILEoption and show an example of how to set it.
set(argSingle LEAK_CHECK SUPPRESSIONS_FILE)
Valgrind.cmake:325
- There are no tests covering the new
SUPPRESSIONS_FILEbehavior; consider adding a CI test or example target that verifies the suppression file is correctly applied.
if (x_SUPPRESSIONS_FILE)
sbmueller
pushed a commit
to swift-nav/albatross
that referenced
this pull request
Jul 9, 2025
…grind memcheck [AP-3695] (#185) (#516) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 361035b6 -> 61cdba17 - 61cdba17 : Add option for suppression file in valgrind memcheck [AP-3695] (swift-nav/cmake#185) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/20444/. [AP-3695]: https://swift-nav.atlassian.net/browse/AP-3695?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
sbmueller
pushed a commit
to swift-nav/libsbp
that referenced
this pull request
Jul 9, 2025
…grind memcheck [AP-3695] (#185) (#1482) Automated PR by Jenkins. If CI has passed successfully, merge away! **cmake** 361035b6 -> 61cdba17 - 61cdba17 : Add option for suppression file in valgrind memcheck [AP-3695] (swift-nav/cmake#185) This pull request was created by https://jenkins.ci.swift-nav.com/job/CI%20Infra/job/submodule-update/20444/. [AP-3695]: https://swift-nav.atlassian.net/browse/AP-3695?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind memcheck supports suppression files. This change allows using our cmake logic to specify a suppression file relative to the repo root.
Tested: https://github.com/swift-nav/starling/pull/9972