Skip to content

Fix rust release.toml and haskell sbp.cabal. #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

john-michaelburke
Copy link
Contributor

@john-michaelburke john-michaelburke commented Apr 13, 2022

Description

@swift-nav/devinfra

Rust

There were some breaking changes in cargo-release recently. These changes are needed to use cargo-release on versions beyond 0.19.0, currently it is running at 0.20.0. An alternative approach would be to fix the version we install but this change seems reasonable to me.

Here is where the breaking changes occurred:
https://github.com/crate-ci/cargo-release/releases/tag/v0.19.0

Haskell

I was unable to publish to hackage without fixing this cabal file. I think the >= format is not valid anymore. Here is the error:

Packages relying on Cabal 1.12 or later should specify a specific version of the Cabal spec of the form 'cabal-version: x.y'. Use 'cabal-version: 1.22'.

Looks like there was a breaking change in 2.0: haskell/cabal#4899

Other concerns

  • We need to upgrade the rust version in the docker container as the newer version of cargo-release requires 2021 version. There were some strange permission issues trying to upgrade the toolchain in the docker. Is there documentation on how to rebuild and deploy the docker tag somewhere?

@john-michaelburke john-michaelburke changed the title Fix rust release.toml breaking changes. Fix rust release.toml and haskell sbp.cabal. Apr 13, 2022
@john-michaelburke john-michaelburke marked this pull request as ready for review April 13, 2022 22:30
@john-michaelburke john-michaelburke requested a review from a team as a code owner April 13, 2022 22:30
@silverjam
Copy link
Contributor

silverjam commented Apr 13, 2022

  • We need to upgrade the rust version in the docker container as the newer version of cargo-release requires 2021 version. There were some strange permission issues trying to upgrade the toolchain in the docker. Is there documentation on how to rebuild and deploy the docker tag somewhere?

The libsbp-build image is managed here: https://github.com/swift-nav/docker-recipes -- so shouldn't be anything special required.

@john-michaelburke john-michaelburke merged commit f5c08f1 into master Apr 13, 2022
@john-michaelburke john-michaelburke deleted the john-michaelburke/fix-release-toml branch April 13, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants