Cleanup toolchain wrapper files [IO-410] #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up leftover toolchain wrapper scripts by fixing a typo in the Bazel flag and normalizing path quoting for bzlmod support.
- Correct
--actionv_envto--action_envin all wrapper comments - Quote
toolchain_bindir_as_bzlmodassignments to embed literal~sequences
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cc/toolchains/musl/x86_64/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/musl/armhf/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/musl/aarch64/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-strip | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-ranlib | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-objdump | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-objcopy | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-nm | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-ld | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-gcov | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-gcc | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-g++ | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-cpp | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-clang | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-as | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/x86_64-w64-mingw32uwp-ar | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm_x86_64_windows/wrappers/wrappers | Fix flag typo & quote bzlmod path |
| cc/toolchains/llvm/x86_64-linux/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/llvm/x86_64-darwin/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/llvm/x86_64-aarch64-linux/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/llvm/aarch64-linux/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/llvm/aarch64-darwin/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/gcc_arm_gnu_8_3/wrappers/wrapper | Fix Bazel flag typo |
| cc/toolchains/gcc_arm_embedded/wrappers/wrapper | Fix Bazel flag typo |
martin4861
changed the title
reimerix
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#157 has some leftover cleanup tasks for the toolchain wrapper files.
The changes affect only the Bazel 7
bzl_modbuild and a test PR is linked.