Skip to content

Conversation

fabianfett
Copy link
Member

We want to be able to efficiently encode Redis commands that are sent to a server. This patch adds a new RedisCommandEncoder that allows us to efficiently create Redis commands without needing to go through RESP representations, that may require us to create Arrays. Further it introduces a RESP3BlobStringEncodable that must be implement to send blob strings using RedisCommandEncoder. This patch also adds implementations for String and ByteBuffer for the new RESP3BlobStringEncodable protocol.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Jun 21, 2023
@fabianfett fabianfett requested a review from Joannis June 21, 2023 15:32
We want to be able to efficiently encode Redis commands that are sent to a server. This patch adds a new `RedisCommandEncoder` that allows us to efficiently create Redis commands without needing to go through RESP representations, that may require us to create Arrays. Further it introduces a `RESP3BlobStringEncodable` that must be implement to send blob strings using `RedisCommandEncoder`. This patch also adds implementations for `String` and  `ByteBuffer` for the new `RESP3BlobStringEncodable` protocol.
@fabianfett fabianfett force-pushed the ff-add-RedisCommandEncoder branch from c5b32aa to 89bf654 Compare June 21, 2023 15:37
@fabianfett fabianfett merged commit 018a9b9 into swift-server:main Jul 3, 2023
@fabianfett fabianfett deleted the ff-add-RedisCommandEncoder branch July 3, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants