Properties of HTTPResponses are now var #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Oct 13, 2020
tomerd
reviewed
Oct 13, 2020
|
|
||
| public init( | ||
| statusCode: HTTPResponseStatus, | ||
| headers: HTTPHeaders? = nil, | ||
| multiValueHeaders: HTTPMultiValueHeaders? = nil, |
There was a problem hiding this comment.
It never was supported in the first place. My mistake. Quote from docu:
To customize the response, your Lambda function should return a response with the following format.hv
{ "cookies" : ["cookie1", "cookie2"], "isBase64Encoded": true|false, "statusCode": httpStatusCode, "headers": { "headerName": "headerValue", ... }, "body": "Hello from Lambda!" }
There was a problem hiding this comment.
sounds good, need to point out in the release notes
tomerd
reviewed
Oct 13, 2020
stevapple
added a commit
to stevapple/swift-tencent-scf-runtime
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties of HTTPResponse types should be
varnotletMotivation:
When creating responses in Lambda developers might want to create the response in multiple steps changing and adding properties. As of now this is not possible since all HTTPResponse types only have
letproperties. If a developer wants to mark a response as immutable they have still the option to mark the complete response aslet.Modifications:
APIGateway.Response,APIGateway.V2.Response,ALB.TargetGroupResponse) are nowvariableAPIGateway.V2.Response. See example/documentation at the very endResult:
Developers have an easier job creating responses. 🥳