Renamed completeWithAsync to completeWithTask #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fabianfett merged 3 commits into swift-server:main from saltzmanjoelh:main

Aug 19, 2021

saltzmanjoelh commented Aug 18, 2021

In swift-nio completeWithAsync was renamed to completeWithTask
apple/swift-nio@e66b64e

Motivation:

completeWithAsync causes build errors on macOS 12 and Xcode 13

Modifications:

Renamed completeWithAsync to completeWithTask

Result:

No more build errors

Joel Saltzman added 2 commits

August 18, 2021 11:03


          Renamed completeWithAsync to completeWithTask

f215e56

apple/swift-nio@e66b64e


          Merge pull request #1 from saltzmanjoelh/saltzmanjoelh-completeWithTask

39a2d33

Renamed completeWithAsync to completeWithTask

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

6 similar comments

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

swift-server-bot commented Aug 18, 2021

Can one of the admins verify this patch?

fabianfett approved these changes

View reviewed changes

Member

fabianfett commented Aug 18, 2021

@swift-server-bot test this please

fabianfett requested changes

View reviewed changes

Member

fabianfett left a comment

@saltzmanjoelh Thanks for providing this fix. Since this change was made in the latest SwiftNIO release, we will need to update the SwiftNIO requirement to 2.32.0 in the Package.swift as well.

fabianfett requested a review from tomerd

August 18, 2021 19:33

Member

fabianfett commented Aug 18, 2021

@tomerd I think we should cherry-pick this with #218 into a patch release.

Author

saltzmanjoelh commented Aug 18, 2021

@saltzmanjoelh Thanks for providing this fix. Since this change was made in the latest SwiftNIO release, we will need to update the SwiftNIO requirement to 2.32.0 in the Package.swift as well.

On it...


          Updated swift-nio dependency to 2.32.0

e78f903

Author

saltzmanjoelh commented Aug 18, 2021

@fabianfett Done.

Member

fabianfett commented Aug 18, 2021

@swift-server-bot test this please

fabianfett approved these changes

View reviewed changes

tomerd added the 🔨 semver/patch label

tomerd approved these changes

View reviewed changes

Contributor

tomerd commented Aug 18, 2021

thanks @saltzmanjoelh

tomerd added 🆕 semver/minor and removed 🔨 semver/patch labels

Author

saltzmanjoelh commented Aug 18, 2021

@tomerd My pleasure.

Is it failing on 5.6 though?
https://ci.swiftserver.group/job/swift-aws-lambda-runtime-swift-nightly-prb/86/console

12:42:48 [187/219] Compiling _NIOConcurrency AsyncAwaitSupport.swift
12:42:48 /code/.build/checkouts/swift-nio/Sources/_NIOConcurrency/AsyncAwaitSupport.swift:72:39: error: cannot use parameter 'body' with a non-sendable type '() async throws -> Value' from concurrently-executed code
12:42:48                 let value = try await body()
12:42:48                                       ^

12:42:48 /code/.build/checkouts/swift-nio/Sources/_NIOConcurrency/AsyncAwaitSupport.swift:72:39: note: a function type must be marked '@Sendable' to conform to 'Sendable'
12:42:48                 let value = try await body()
12:42:48                                       ^
12:42:48 error: fatalError
12:42:49 Build step 'Execute shell' marked build as failure

Member

fabianfett commented Aug 18, 2021

@saltzmanjoelh this is an issue in SwiftNIO: apple/swift-nio#1943

Author

saltzmanjoelh commented Aug 18, 2021

@fabianfett Ah! Ok thanks!

fabianfett merged commit 245674c into swift-server:main

fabianfett added this to the 1.0.0-alpha.1 milestone

fabianfett pushed a commit that referenced this pull request


          Renamed completeWithAsync to completeWithTask (#221)

f9d10b2

* Renamed EventLoopPromise's `completeWithAsync` to `completeWithTask` (based on the SwiftNIO renaming)
* Updated swift-nio dependency to 2.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor