Lambda factory as a protocol requirement. #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
reviewed
Jan 6, 2022
| /// - parameters: | ||
| /// - factory: A `ByteBufferLambdaHandler` factory. | ||
| /// | ||
| /// - note: This is a blocking operation that will run forever, as its lifecycle is managed by the AWS Lambda Runtime Engine. |
tomerd
reviewed
Jan 6, 2022
| /// - factory: A `ByteBufferLambdaHandler` factory. | ||
| /// | ||
| /// - note: This is a blocking operation that will run forever, as its lifecycle is managed by the AWS Lambda Runtime Engine. | ||
| internal static func run<Handler: ByteBufferLambdaHandler>(configuration: Configuration = .init(), handlerType: Handler.Type) -> Result<Int, Error> { |
There was a problem hiding this comment.
I guess needed for the generics?
There was a problem hiding this comment.
Yes. It is there to make the user declare the Generic type. Otherwise the user would need to write:
Lambda.run<Handler>()
tomerd
reviewed
Jan 6, 2022
| /// connections and HTTP clients for example. It is encouraged to use the given `EventLoop`'s conformance | ||
| /// to `EventLoopGroup` when initializing NIO dependencies. This will improve overall performance, as it | ||
| /// minimizes thread hopping. | ||
| static func factory(context: Lambda.InitializationContext) -> EventLoopFuture<Self> |
There was a problem hiding this comment.
maybe makeHandler or makeInstance? factory is generally not popular term in Swift. cc @weissi for ideas
There was a problem hiding this comment.
Yeah, generally "make" is the word to use; makeHandler would work too.
tomerd
reviewed
Jan 6, 2022
| /// The lambda runtime provides a default implementation of the method that manages the launch | ||
| /// process. | ||
| public static func main() { | ||
| _ = Lambda.run(configuration: .init(), handlerType: Self.self) |
There was a problem hiding this comment.
should we mark Lambda::run @discardableResult?
There was a problem hiding this comment.
I think the Lambda.run method should not return anything. But I haven't made my mind up about this fully. Would like to tackle later.
tomerd
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed...
We want to use the same lambda application lifecycle for all lambda implementations. Currently we support
@mainonly for theLambdaHandlerprotocol. This PR brings the@mainfunctionality to the lower level protocols.Modifications:
ByteBufferLambdaHandlerprotocolHandlerFactory) from theLambdaRuntimeandLambdaLambdaRuntimegeneric over theLambdaHandlertypeResult: