Skip to content

Remove superfluous guard statements #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove superfluous guard statements #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions Tests/IntegrationTests/KafkaTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ final class KafkaTests: XCTestCase {
// Consumer Task
group.addTask {
var consumedMessages = [KafkaConsumerMessage]()
for try await messageResult in consumer.messages {
guard case let message = messageResult else {
continue
}
for try await message in consumer.messages {
consumedMessages.append(message)

if consumedMessages.count >= testMessages.count {
Expand Down Expand Up @@ -192,10 +189,7 @@ final class KafkaTests: XCTestCase {
// Consumer Task
group.addTask {
var consumedMessages = [KafkaConsumerMessage]()
for try await messageResult in consumer.messages {
guard case let message = messageResult else {
continue
}
for try await message in consumer.messages {
consumedMessages.append(message)

if consumedMessages.count >= testMessages.count {
Expand Down Expand Up @@ -258,10 +252,7 @@ final class KafkaTests: XCTestCase {
// Consumer Task
group.addTask {
var consumedMessages = [KafkaConsumerMessage]()
for try await messageResult in consumer.messages {
guard case let message = messageResult else {
continue
}
for try await message in consumer.messages {
consumedMessages.append(message)
try await consumer.commitSync(message)

Expand Down Expand Up @@ -327,10 +318,7 @@ final class KafkaTests: XCTestCase {
// First Consumer Task
group.addTask {
var consumedMessages = [KafkaConsumerMessage]()
for try await messageResult in consumer1.messages {
guard case let message = messageResult else {
continue
}
for try await message in consumer1.messages {
consumedMessages.append(message)

// Only read first half of messages
Expand Down Expand Up @@ -392,10 +380,7 @@ final class KafkaTests: XCTestCase {
// Second Consumer Task
group.addTask {
var consumedMessages = [KafkaConsumerMessage]()
for try await messageResult in consumer2.messages {
guard case let message = messageResult else {
continue
}
for try await message in consumer2.messages {
consumedMessages.append(message)

// Read second half of messages
Expand Down