Skip to content

Wrap rd_kafka_consumer_poll into iterator (use librdkafka embedded backpressure) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 26, 2024
Merged

Wrap rd_kafka_consumer_poll into iterator (use librdkafka embedded backpressure) #158

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d400265
remove message sequence
blindspotbounty Dec 8, 2023
abee905
test consumer with implicit rebalance
blindspotbounty Dec 11, 2023
8cbe011
misc + format
blindspotbounty Dec 11, 2023
c39fd87
remove artefact
blindspotbounty Dec 11, 2023
a69bead
don't check a lot of messages
blindspotbounty Dec 11, 2023
0f538db
fix typo
blindspotbounty Dec 11, 2023
477ae0e
slow down first consumer to lower message to fit CI timeout
blindspotbounty Dec 12, 2023
f96a5bc
remove helpers
blindspotbounty Dec 12, 2023
801f302
use exact benchmark version to avoid missing thresholds error (as no …
blindspotbounty Dec 12, 2023
7041a2b
Merge remote-tracking branch 'swift-server/main' into get-rid-of-cons…
blindspotbounty Apr 10, 2024
207d0c2
add deprecated marks for backpressure, change comment for future dev
blindspotbounty Apr 16, 2024
bd11be5
address comments
blindspotbounty Apr 26, 2024
1fdf491
Merge branch 'main' into get-rid-of-consumer-message-async-sequence
blindspotbounty Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions Sources/Kafka/Configuration/KafkaConsumerConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
//
//===----------------------------------------------------------------------===//

import Crdkafka
import struct Foundation.UUID

public struct KafkaConsumerConfiguration {
Expand All @@ -25,30 +24,20 @@ public struct KafkaConsumerConfiguration {

/// A struct representing different back pressure strategies for consuming messages in ``KafkaConsumer``.
public struct BackPressureStrategy: Sendable, Hashable {
enum _BackPressureStrategy: Sendable, Hashable {
case watermark(low: Int, high: Int)
}

let _internal: _BackPressureStrategy

private init(backPressureStrategy: _BackPressureStrategy) {
self._internal = backPressureStrategy
}

/// A back pressure strategy based on high and low watermarks.
///
/// The consumer maintains a buffer size between a low watermark and a high watermark
/// to control the flow of incoming messages.
///
/// - Parameter low: The lower threshold for the buffer size (low watermark).
/// - Parameter high: The upper threshold for the buffer size (high watermark).
public static func watermark(low: Int, high: Int) -> BackPressureStrategy {
return .init(backPressureStrategy: .watermark(low: low, high: high))
@available(*, deprecated, message: "Use MessageOptions to control backpressure")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to depreciate stuff here. We aren't 1.0.0 yet so let's just remove it!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed deprecated code.

public static func watermark(low _: Int, high _: Int) -> BackPressureStrategy {
return .init()
}
}

/// The backpressure strategy to be used for message consumption.
/// See ``KafkaConsumerConfiguration/BackPressureStrategy-swift.struct`` for more information.
@available(*, deprecated, message: "Use message.maximumBytes and message.maximumBytesToCopy to control backpressure")
public var backPressureStrategy: BackPressureStrategy = .watermark(
low: 10,
high: 50
Expand Down
Loading