Fix: KafkaConsumer.commitSync should not block
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixschlegel
force-pushed
the
fs-kafka-commit-sync-stop-blocking
branch
from
8ded307 to
36f22ba
Compare
felixschlegel
force-pushed
the
fs-kafka-commit-sync-stop-blocking
branch
from
36f22ba to
2bd1639
Compare
Motivation: Currently our invocation to `rd_kafka_commit` inside of `KafkaCosumer.commitSync` is blocking a cooperative thread. This PR aims to make `KafkaCosumer.commitSync` non-blocking by using the callback-based commit API. Modifications: * move `commitSync` logic to `KafkaClient` * replace the blocking invocation to [rd_kafka_commit](https://docs.confluent.io/platform/current/clients/librdkafka/html/rdkafka_8h.html#ab96539928328f14c3c9177ea0c896c87) with a callback-based invocation to [rd_kafka_commit_queue](https://docs.confluent.io/platform/current/clients/librdkafka/html/rdkafka_8h.html#af76a6a73baa9c2621536e3f6882a3c1a) which is then wrapped inside a `withAsyncThrowingContinuation` statement
felixschlegel
force-pushed
the
fs-kafka-commit-sync-stop-blocking
branch
from
2bd1639 to
92fce97
Compare
|
Implemented in #73 , closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently our invocation to
rd_kafka_commitinside ofKafkaCosumer.commitSyncis blocking a cooperative thread.This PR aims to make
KafkaCosumer.commitSyncnon-blocking by using thecallback-based commit API.
Modifications:
commitSynclogic toKafkaClientwhich is then wrapped inside a
withAsyncThrowingContinuationstatement