[6.0] Return timestamp of latest unit for file in seconds not nanoseconds

[ahoppen]

• Explanation: We were incorrectly returning a timestamp as nanoseconds instead of seconds in indexstoredb_timestamp_of_latest_unit_for_file
• Scope: The indexstoredb_timestamp_of_latest_unit_for_file function introduced a few weeks ago that doesn’t have any users yet
• Risk: Very low, the function hasn’t been used so far
• Testing: Tested that this fixes an issue I was seeing in SourceKit-LSP
• Issue: n/a
• Reviewer: @bnbarham on Return timestamp of latest unit for file in seconds not nanoseconds #190

[akyrtzi]

Why not use a more precise timestamp than only up-to-second fidelity?

[ahoppen]

It’s returning a double, so it does have sub-second fidelity.

[akyrtzi]

Ah thanks for clarifying!

[bnbarham]

Given I had the exact same question, let's change this API to return a 64 bit int and nanoseconds instead. But we can take the fix to unblock things for now 👍

[ahoppen]

Agreed to change the API to return nanoseconds in a follow-up PR.