Skip to content

Target: print the message with formatting #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 1, 2020

The message has a format specifier but was being printed unformatted.
This corrects the macro usage to use the formatting version. Improves
the debug logging only.

@compnerd
Copy link
Member Author

compnerd commented Apr 1, 2020

CC: @JDevlieghere @adrian-prantl

@compnerd
Copy link
Member Author

compnerd commented Apr 1, 2020

@swift-ci please test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also cherry-pick to swift/master-next, there is no automerger in this direction!

The message has a format specifier but was being printed unformatted.
This corrects the macro usage to use the formatting version.  Improves
the debug logging only.
@compnerd
Copy link
Member Author

compnerd commented Apr 2, 2020

Stupid MSVC let this through, thanks clang!

@compnerd
Copy link
Member Author

compnerd commented Apr 2, 2020

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Apr 2, 2020

Please also cherry-pick to swift/master-next, there is no automerger in this direction!

Thanks for the heads up, will do. I wonder if it would be reasonable to have an automerger for this direction (CC: @shahmishal)

@adrian-prantl
Copy link

Please also cherry-pick to swift/master-next, there is no automerger in this direction!

Thanks for the heads up, will do. I wonder if it would be reasonable to have an automerger for this direction (CC: @shahmishal)

Unfortunately it's not quite as straight-forward, or we would have one already :-)

IIRC, it would have to be an auto-cherry-picker. @fredriss remembers all the details.

@fredriss
Copy link

fredriss commented Apr 2, 2020

Please also cherry-pick to swift/master-next, there is no automerger in this direction!

Thanks for the heads up, will do. I wonder if it would be reasonable to have an automerger for this direction (CC: @shahmishal)

Unfortunately it's not quite as straight-forward, or we would have one already :-)

IIRC, it would have to be an auto-cherry-picker. @fredriss remembers all the details.

There was an automerger in this direction before the monorepo. But in the monorepo world, we cannot merge all the llvm and clang content from the stable branch into swift/master-next. I'm working on automation to point out the commits that are missing on master-next , but it's gonna take some time to become real.

@compnerd compnerd merged commit 06099c0 into swiftlang:swift/master Apr 2, 2020
@compnerd compnerd deleted the print-formatting branch April 2, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants