-
Notifications
You must be signed in to change notification settings - Fork 339
Target: print the message with formatting #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also cherry-pick to swift/master-next, there is no automerger in this direction!
The message has a format specifier but was being printed unformatted. This corrects the macro usage to use the formatting version. Improves the debug logging only.
e343b7f
to
187b331
Compare
Stupid MSVC let this through, thanks clang! |
@swift-ci please test |
Thanks for the heads up, will do. I wonder if it would be reasonable to have an automerger for this direction (CC: @shahmishal) |
Unfortunately it's not quite as straight-forward, or we would have one already :-) IIRC, it would have to be an auto-cherry-picker. @fredriss remembers all the details. |
There was an automerger in this direction before the monorepo. But in the monorepo world, we cannot merge all the llvm and clang content from the stable branch into swift/master-next. I'm working on automation to point out the commits that are missing on master-next , but it's gonna take some time to become real. |
The message has a format specifier but was being printed unformatted.
This corrects the macro usage to use the formatting version. Improves
the debug logging only.