[lldb] Improve handling of indirect enums using reflection metadata #10148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests for several kinds of indirect enums that were previously uncovered, such as GADTs and generic single-payload enums and implements the proper handling of the ClosureContext box these payloads come packaged in. This fixes a lot of edge cases that previously required a SwiftASTContext to resolve properly. rdar://145301500
|
test with swiftlang/swift#79700 |
|
test with swiftlang/swift#79700 |
adrian-prantl
requested review from
augusto2112 and
kastiglione
and removed request for
a team
|
test with swiftlang/swift#79700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for several kinds of indirect enums that were previously uncovered, such as GADTs and generic single-payload enums and implements the proper handling of the ClosureContext box these payloads come packaged in.
This fixes a lot of edge cases that previously required a SwiftASTContext to resolve properly.
rdar://145301500