Skip to content

Fix windows build failures with MSVC #11092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Fix windows build failures with MSVC #11092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d97270
Use llvm::popcount instead of __builtin_popcount.
hjyamauchi Jul 30, 2025
7524778
Set the underlying type of enum BoundsSafetyNewChecks to unsigned.
hjyamauchi Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/LangOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ class LangOptionsBase {
};

/* TODO(BoundsSafety) Deprecate the flag */
enum BoundsSafetyNewChecks {
enum BoundsSafetyNewChecks : unsigned {
BS_CHK_None = 0,

BS_CHK_AccessSize = 1 << 0, // rdar://72252593
Expand Down
2 changes: 1 addition & 1 deletion clang/unittests/Tooling/BoundsSafetyBringupMissingChecks.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ TEST(BoundsSafetyBringUpMissingChecks, ChkPairValidMask) {
static_assert(LangOptions::BS_CHK_None == 0, "expected 0");
for (size_t Idx = 0; Idx < NumChkDescs; ++Idx) {
unsigned CurrentMask = CheckKinds[Idx].Mask;
EXPECT_EQ(__builtin_popcount(CurrentMask), 1); // Check is a power of 2
EXPECT_EQ(llvm::popcount(CurrentMask), 1); // Check is a power of 2
EXPECT_EQ(SeenBits & CurrentMask,
0U); // Doesn't overlap with a previously seen value
SeenBits |= CurrentMask;
Expand Down