[stable/21.x][cmake] lldb: Turn of clang visibility macros if not CLANG_LINK_CLANG_DYLIB
#11127
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
commented
Aug 5, 2025
Comment on lines
+95
to
109
| if(MSVC AND NOT CLANG_LINK_CLANG_DYLIB) | ||
| # Make sure all consumers also turn off visibility macros so the're not | ||
| # trying to dllimport symbols. | ||
| target_compile_definitions(${name} PUBLIC CLANG_BUILD_STATIC) | ||
| if(TARGET "obj.${name}") | ||
| target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC) | ||
| endif() | ||
| elseif(NOT PARAM_SHARED AND NOT PARAM_STATIC) | ||
| # lldb component libraries linked in to clang-cpp are declared without | ||
| # SHARED or STATIC. | ||
| target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS) | ||
| endif() | ||
|
|
||
| if(CLANG_LINK_CLANG_DYLIB) | ||
| target_link_libraries(${name} PRIVATE clang-cpp) |
There was a problem hiding this comment.
This
if(MSVC AND NOT CLANG_LINK_CLANG_DYLIB)
...
elseif(NOT PARAM_SHARED AND NOT PARAM_STATIC)
target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS)
endif()
...
if(CLANG_LINK_CLANG_DYLIB)
target_link_libraries(${name} PRIVATE clang-cpp)flow is odd.
There was a problem hiding this comment.
idk why i did it that way, but do the LLDB libraries even need there API exported from the clang shared library anyway? I should also mention @andrurogerz is continuing most of the work on this now.
There was a problem hiding this comment.
I think there is something off with the way the CLANG_ABI annotation definitions are gated right now in LLVM main. I found yesterday that after annotating a bunch of the clang symbols the project doesn't build on Windows even when you don't enable DLL builds. I have not looked into the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mirrors
https://github.com/llvm/llvm-project/pull/108276/files#diff-4dd645a8b76bb3886a505258a8c2e598aeddea770e7b0a2b51689124a5ea6e9a.