Skip to content

[lldb] Compute reflection context in TaskSyntheticFrontEnd #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[lldb] Compute reflection context in TaskSyntheticFrontEnd #11136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions lldb/source/Plugins/Language/Swift/SwiftFormatters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,14 +917,15 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
// Remove any bogus child tasks.
// Very rarely, the child tasks include a bogus task which has an
// invalid task id of 0.
llvm::erase_if(tasks, [&](auto task_ptr) {
if (auto task_info =
expectedToOptional(m_reflection_ctx->asyncTaskInfo(task_ptr)))
return task_info->id == 0;
// Don't filter children with errors here. Let these tasks reach the
// formatter's existing error handling.
return false;
});
if (auto reflection_ctx = GetReflectionContext())
llvm::erase_if(tasks, [&](auto task_ptr) {
if (auto task_info =
expectedToOptional(reflection_ctx->asyncTaskInfo(task_ptr)))
return task_info->id == 0;
// Don't filter children with errors here. Let these tasks reach the
// formatter's existing error handling.
return false;
});

std::string mangled_typename =
mangledTypenameForTasksTuple(tasks.size());
Expand Down Expand Up @@ -970,15 +971,14 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
}

lldb::ChildCacheState Update() override {
if (auto *runtime = SwiftLanguageRuntime::Get(m_backend.GetProcessSP())) {
m_reflection_ctx = runtime->GetReflectionContext();
if (auto reflection_ctx = GetReflectionContext()) {
ValueObjectSP task_obj_sp = m_backend.GetChildMemberWithName("_task");
if (!task_obj_sp)
return ChildCacheState::eRefetch;
m_task_ptr = task_obj_sp->GetValueAsUnsigned(LLDB_INVALID_ADDRESS);
if (m_task_ptr != LLDB_INVALID_ADDRESS) {
llvm::Expected<ReflectionContextInterface::AsyncTaskInfo> task_info =
m_reflection_ctx->asyncTaskInfo(m_task_ptr);
reflection_ctx->asyncTaskInfo(m_task_ptr);
if (auto err = task_info.takeError()) {
LLDB_LOG_ERROR(
GetLog(LLDBLog::DataFormatters | LLDBLog::Types), std::move(err),
Expand Down Expand Up @@ -1010,7 +1010,12 @@ class TaskSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
}

private:
ThreadSafeReflectionContext m_reflection_ctx;
ThreadSafeReflectionContext GetReflectionContext() {
if (auto *runtime = SwiftLanguageRuntime::Get(m_backend.GetProcessSP()))
return runtime->GetReflectionContext();
return {};
}

TypeSystemSwiftTypeRef *m_ts = nullptr;
addr_t m_task_ptr = LLDB_INVALID_ADDRESS;
ReflectionContextInterface::AsyncTaskInfo m_task_info;
Expand Down