[BoundsSafety] Allow using bounds-attributed types when deducing auto #11463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykstefanski
requested review from
delcypher,
hnrklssn,
rapidsna and
ziqingluo-90
patrykstefanski
added
the
clang:bounds-safety
hnrklssn
reviewed
Sep 20, 2025
delcypher
requested changes
Sep 22, 2025
patrykstefanski
force-pushed
the
eng/pstefanski/PR-140995829
branch
from
08b300d to
c65fa57
Compare
Allow using bounds-attributed types when deducing auto type in attribute-only mode. Since the bounds-attributed type can depend on a variable in a different scope etc., we drop the bounds-attributed sugar and emit a warning. rdar://140995829
patrykstefanski
force-pushed
the
eng/pstefanski/PR-140995829
branch
from
c65fa57 to
6b8f628
Compare
|
As discussed on slack, I removed support for inferring |
delcypher
approved these changes
Sep 24, 2025
|
@swift-ci test llvm |
| if (const auto *CATy = dyn_cast<CountAttributedType>(BATy)) { | ||
| DesugaredTy = CATy->desugar(); | ||
| Kind = CATy->getKind(); | ||
| } else { |
There was a problem hiding this comment.
auto will get __null_terminated without any warnings/errors:
void foo(int *__null_terminated x) {
__auto_type p = x;
auto r = x;
}
FunctionDecl foo 'void (int * __terminated_by(0))'
|-ParmVarDecl used x 'int * __terminated_by(0)':'int *'
`-CompoundStmt
|-DeclStmt
| `-VarDecl p 'int * __terminated_by(0)':'int *' cinit
| `-ImplicitCastExpr 'int * __terminated_by(0)':'int *' <LValueToRValue>
| `-DeclRefExpr 'int * __terminated_by(0)':'int *' lvalue ParmVar 'x' 'int * __terminated_by(0)':'int *'
`-DeclStmt
`-VarDecl r 'int * __terminated_by(0)':'int *' cinit
`-ImplicitCastExpr 'int * __terminated_by(0)':'int *' <LValueToRValue>
`-DeclRefExpr 'int * __terminated_by(0)':'int *' lvalue ParmVar 'x' 'int * __terminated_by(0)':'int *'
|
Unrelated tests are failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using bounds-attributed types when deducing auto type in attribute-only mode. Since the bounds-attributed sugar would depend on a variable in a different scope etc, we drop the sugar and emit a warning.
rdar://140995829