Skip to content

Test empty PR #6503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Test empty PR #6503

wants to merge 1 commit into from

Conversation

ributzka
Copy link

No description provided.

@ributzka
Copy link
Author

@swift-ci please test

@ributzka ributzka closed this Oct 6, 2023
@ributzka ributzka deleted the eng/PR-106578342-test branch October 6, 2023 15:58
swift-ci pushed a commit that referenced this pull request Sep 19, 2024
@kovdan01 @atrosinenko
[PAC][CodeGen] Do not emit trivial 'mov xN, xN' on tail call (llvm#10…
3d5e8e4 
…9100)

Under some conditions, a trivial `mov xN xN` instruction was emitted on
tail calls. Consider the following code:

```
class Test {
public:
  virtual void f() {}
};

void call_f(Test *t) {
  t->f();
}
```

Correponding assembly:

```
_Z6call_fP4Test:
        ldr     x16, [x0]
        mov     x17, x0
        movk    x17, #6503, lsl #48
        autda   x16, x17
        ldr     x1, [x16]
 =====> mov     x16, x16
        movk    x16, llvm#54167, lsl #48
        braa    x1, x16
```

This patch makes such movs being omitted.

Co-authored-by: Anatoly Trosinenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ributzka