Skip to content

Temporarily re-expose GTest #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link

@etcwilde etcwilde commented Aug 3, 2023

LLVM hid GTest from folks that aren't building as part of LLVM, or that aren't installing GTest. While this is the right thing to do and is totally sensible, it doesn't work with Swift, which does neither. Re-expose GTest for now. This should get cleaned up once Swift builds things reasonably.

LLVM hid GTest from folks that aren't building as part of LLVM, or that
aren't installing GTest. While this is the right thing to do and is
totally sensible, it doesn't work with Swift, which does neither.
Re-expose GTest for now. This should get cleaned up once Swift builds
things reasonably.
@etcwilde etcwilde requested a review from bnbarham August 3, 2023 16:56
@etcwilde
Copy link
Author

etcwilde commented Aug 3, 2023

@swift-ci please test

@etcwilde etcwilde requested a review from compnerd August 3, 2023 16:57
@etcwilde
Copy link
Author

etcwilde commented Aug 4, 2023

@swift-ci please test

@shahmishal
Copy link
Member

Needs this to run PR testing: swiftlang/swift#67741

@etcwilde
Copy link
Author

etcwilde commented Aug 4, 2023

I am confused by the failure.

Exception: ['git', '--git-dir', '/tmp/jenkins-a6c9e913/workspace/pr-apple-llvm-project-linux/branch-stable/20230725/swift-asn1/.git', '--work-tree', '/tmp/jenkins-a6c9e913/workspace/pr-apple-llvm-project-linux/branch-stable/20230725/swift-asn1', 'checkout', 'stable/20230725']

It's trying to checkout a stable/20230725 branch from swift-asn1, but that repo doesn't have a branch or tag with that name. When I look at the update-checkout json object, it looks like it should be trying to check out the 0.8.0 tag; https://github.com/apple/swift/blob/bf666d1a79a2a4afcc76908fcfa3a193f530ee69/utils/update_checkout/update-checkout-config.json#L152C39-L152C39

@shahmishal
Copy link
Member

I am confused by the failure.

Exception: ['git', '--git-dir', '/tmp/jenkins-a6c9e913/workspace/pr-apple-llvm-project-linux/branch-stable/20230725/swift-asn1/.git', '--work-tree', '/tmp/jenkins-a6c9e913/workspace/pr-apple-llvm-project-linux/branch-stable/20230725/swift-asn1', 'checkout', 'stable/20230725']

It's trying to checkout a stable/20230725 branch from swift-asn1, but that repo doesn't have a branch or tag with that name. When I look at the update-checkout json object, it looks like it should be trying to check out the 0.8.0 tag; https://github.com/apple/swift/blob/bf666d1a79a2a4afcc76908fcfa3a193f530ee69/utils/update_checkout/update-checkout-config.json#L152C39-L152C39

Might have missed my comment above - #7137 (comment)

@etcwilde
Copy link
Author

etcwilde commented Aug 4, 2023

swiftlang/swift#67741

@swift-ci please test

@etcwilde
Copy link
Author

etcwilde commented Aug 4, 2023

Same failure with that PR.

@etcwilde etcwilde merged commit 95af47d into swiftlang:stable/20230725 Aug 4, 2023
@etcwilde etcwilde deleted the ewilde/re-expose-gtest branch August 4, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants