[clang][modules] Deprecate module.map in favor of module.modulemap #7256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
LGTM, but some Swift tests are failing, so you won't be able to merge until they're resolved. Also cherry-pick to |
jansvoboda11
approved these changes
Aug 17, 2023
This patch deprecates `module.map` in favor of `module.modulemap`, which has been the preferred form since 2014. The eventual goal is to remove support for `module.map` to reduce the number of stats Clang needs to do while searching for module map files. This patch touches a lot of files, but the majority of them are just renaming tests or references to the file in comments or documentation. The relevant files are: * lib/Lex/HeaderSearch.cpp * include/clang/Basic/DiagnosticGroups.td * include/clang/Basic/DiagnosticLexKinds.td
Bigcheese
force-pushed
the
dev/module.map-depr
branch
from
fd9af6f to
37ce275
Compare
|
@swift-ci please test |
|
Linux failure is unrelated :( |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates
module.mapin favor ofmodule.modulemap, which has been the preferred form since 2014. The eventual goal is to remove support formodule.mapto reduce the number of stats Clang needs to do while searching for module map files.This patch touches a lot of files, but the majority of them are just renaming tests or references to the file in comments or documentation.
The relevant files are: