[lldb][NFC] Expose GetReflectionContext in SwiftLanguageRuntime's API #7658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
commented
Oct 20, 2023
| std::recursive_mutex &mutex) | ||
| : m_reflection_ctx(reflection_ctx), m_lock(mutex, std::adopt_lock) {} | ||
|
|
||
| static ThreadSafeReflectionContext MakeInvalid() { |
There was a problem hiding this comment.
@adrian-prantl @kastiglione I'm not really happy with this, but it's required for returning the "empty" case in the stub language runtime. If you have any ideas on how to make this better I'd be happy to listen.
| } // namespace swift | ||
|
|
||
| namespace lldb_private { | ||
| struct SwiftMetadataCache; |
adrian-prantl
approved these changes
Oct 20, 2023
augusto2112
force-pushed
the
refactor-get-reflection-context
branch
from
cd003f3 to
c00b71b
Compare
|
@swift-ci test |
augusto2112
force-pushed
the
refactor-get-reflection-context
branch
from
c00b71b to
c3b8af3
Compare
|
@swift-ci test |
This is in preparation for building type infos from DWARF, which will need access to the reflection context and it's builder.
augusto2112
force-pushed
the
refactor-get-reflection-context
branch
from
c3b8af3 to
41a8e85
Compare
|
@swift-ci test |
|
@augusto2112 I'm seeing the build fail on Windows after this change: I think the following implies a copy construction, which is not generated because of ThreadSafeReflectionContext GetReflectionContext() {
STUB_LOG();
return ThreadSafeReflectionContext::MakeInvalid();
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for building type infos from DWARF, which will need access to the reflection context and it's builder.