Skip to content

Revert "[ClangScanDeps] Fix cas dependency scanning test after D159064" #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ian-twilightcoder
Copy link

@ian-twilightcoder ian-twilightcoder commented Mar 14, 2024

ab562ed (llvm#84127) reverses the part of D159064 that originally broke these tests.

This reverts commit 2bbc0e4.

rdar://124628894

@cachemeifyoucan
Copy link

Can you explain the reason for the revert in the commit message?

@ian-twilightcoder
Copy link
Author

Can you explain the reason for the revert in the commit message?

Updated the commit message and PR summary

Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

swiftlang@ab562ed (llvm#84127) reverses the part of D159064 that originally broke these tests.

This reverts commit 2bbc0e4.

rdar://124628894
@ian-twilightcoder
Copy link
Author

@swift-ci test llvm

@ian-twilightcoder ian-twilightcoder merged commit 401b437 into swiftlang:next Mar 15, 2024
@ian-twilightcoder ian-twilightcoder deleted the fix-scan-deps branch March 15, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants