[lldb] Split TestSwiftEmbeddedFrameVariable into two tests #8464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
commented
Mar 22, 2024
augusto2112
commented
For testing purposes, it's useful to have a setting to disable the instantiation of SwiftASTContext, to ensure that TypeSystemSwiftTypeRef, which by default falls back to it on failure, is working independently. This setting might also be useful for end users, as when debugging a program that was built with a different compiler version versus what is embedded in LLDB instantiation of Swift AST contexts would be moot.
Split TestSwiftEmbeddedFrameVariable into one test that runs with instantiation of SwiftASTContext enabled, and one that runs with it disabled. The first one is useful because of the validation code that compares TypeSystemSwiftTypeRef results with SwiftASTContext's. The second one is useful to validate that the test is passing without TypeSystemSwiftTypeRef falling back to SwiftASTContext.
|
@swift-ci test |
|
@adrian-prantl there are 3 commits here, it's probably easier to check them separately |
adrian-prantl
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.