Skip to content

[swift/6.0][lldb] Update for PrintOptions.PrintRegularClangComments removal #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2024
Merged

[swift/6.0][lldb] Update for PrintOptions.PrintRegularClangComments removal #8468

merged 1 commit into from
Mar 28, 2024

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 25, 2024 •
edited
Loading

Cherry-pick #8443 into swift/release/6.0

(Copied from corresponding swift repo PR swiftlang/swift#72574)

  • Explanation: Generated interfaces for Clang modules used to try printing normal comments and whitespaces between decls extracted from the header text. That's was getting confusing mainly because of "import as member" which reorders decls in the header files. So stop printing normal comments for Clang decls.
  • Scope: Generated interface in SourceKit
  • Risk: Low. Changes are simple. Nobody should rely on the comments/whitespaces in generated interfaces
  • Testing: Updated regression test cases
  • Issues: rdar://93731287
  • Reviewers: Alex Hoppen (@ahoppen) Hamish Knight (@hamishknight)

@rintaro
[lldb] Update for PrintOptions.PrintRegularClangComments removal
9147bf0 
PrintRegularClangComments is being removed in swift.

(cherry picked from commit 3979c8a)
@rintaro rintaro mentioned this pull request Mar 25, 2024
Merged
@rintaro
Copy link
Member Author

rintaro commented Mar 25, 2024

swiftlang/swift#72574
@swift-ci Please test

@rintaro rintaro changed the title [lldb] Update for PrintOptions.PrintRegularClangComments removal [swift/6.0][lldb] Update for PrintOptions.PrintRegularClangComments removal Mar 25, 2024
@bnbarham bnbarham self-requested a review March 25, 2024 22:29
@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2024

swiftlang/swift#72574
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2024

swiftlang/swift#72574
@swift-ci Please test macOS

@rintaro
Copy link
Member Author

rintaro commented Mar 27, 2024

@swift-ci Please test

@rintaro rintaro merged commit 588dd92 into swiftlang:swift/release/6.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @bnbarham